svn commit: r456223 - in head/www: . Stikked Stikked/files

Dan Langille dan at langille.org
Thu Dec 14 20:53:29 UTC 2017


> On Dec 14, 2017, at 8:39 AM, Mathieu Arnold <mat at FreeBSD.org> wrote:
> 
> Le 13/12/2017 à 18:44, Dan Langille a écrit :
>> +WANT_PGSQL=	client
>> +WANT_SQLITE=	client
>> +WANT_MYSQL=	client
> 
> What are those for ? You don't use them anywhere in the port.
> 
>> +PGSQL_USE=	PHP=pdo_pgsql
> 
> This is also never used.

That's terrible. I think that is cruft leftover from when I was trying to get this
to work with PDO. I abandoned that when I realized it would also work without.

> 
>> Added: head/www/Stikked/pkg-plist
>> ==============================================================================
>> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
>> +++ head/www/Stikked/pkg-plist	Wed Dec 13 17:44:38 2017	(r456223)
>> @@ -0,0 +1,3436 @@
>> +%%ETCDIR%%/stikked.php.sample
> 
> @sample ?

A valid point, yes, that was my intent.

> 
>> +
> 
> Empty line

I'd always left empty lines between different sections of pkg-plist for readability.  Gone.

See https://svnweb.freebsd.org/ports?view=revision&revision=456372

> 
--
Dan Langille - BSDCan / PGCon
dan at langille.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 625 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20171214/380eccab/attachment.sig>


More information about the svn-ports-head mailing list