svn commit: r448936 - in head/cad/stepcode: . files

Alexey Dokuchaev danfe at FreeBSD.org
Wed Aug 30 09:31:01 UTC 2017


On Tue, Aug 29, 2017 at 07:36:16PM +0000, Kurt Jaeger wrote:
> New Revision: 448936
> URL: https://svnweb.freebsd.org/changeset/ports/448936
> 
> Log:
>   cad/stepcode: Fix portlint issues
>   
>   PR:		221835
> ...
>  CMAKE_ARGS+=	-DSC_INSTALL_PREFIX=${PREFIX} \
>  		-DSC_BUILD_TYPE=Release
> +
> +MANDIRS=	${PREFIX}/man

What does this variable do?  I don't see it referenced anywhere.  Looks
like someone tried to play pass MAN_DIR down to cmake, but failed to do
it properly (see below).

> @@ -0,0 +1,11 @@
> +--- doc/CMakeLists.txt.orig	2017-08-29 15:56:46 UTC
> ++++ doc/CMakeLists.txt
> +@@ -4,7 +4,7 @@ set(sc_MANS
> +   )
> + 
> + if(NOT DEFINED MAN_DIR)
> +-  set(MAN_DIR share/man)
> ++  set(MAN_DIR man)
> + endif(NOT DEFINED MAN_DIR)

Why to patch it when you can pass MAN_DIR via CMAKE_ARGS (together with
other values)?

./danfe


More information about the svn-ports-head mailing list