svn commit: r439421 - in head/www/nginx: . files

[Ian Lepore]

On Thu, 2017-04-27 at 16:46 +0000, Sergey A. Osokin wrote:
> On Thu, Apr 27, 2017 at 08:24:55AM +0200, Mathieu Arnold wrote:
> > 
> > Le 26/04/2017 ?? 18:53, Sergey A. Osokin a ??crit :
> > > 
> > > On Wed, Apr 26, 2017 at 06:18:44PM +0200, Mathieu Arnold wrote:
> > > > 
> > > > Le 26/04/2017 ?? 01:18, Sergey A. Osokin a ??crit :
> > > > > 
> > > > > Author: osa
> > > > > Date: Tue Apr 25 23:18:09 2017
> > > > > New Revision: 439421
> > > > > URL: https://svnweb.freebsd.org/changeset/ports/439421
> > > > > 
> > > > > Log:
> > > > >   Upgrade from 1.10.3 to 1.12.0.
> > > > >   
> > > > >   ChangeLog:	http://nginx.org/en/CHANGES-1.12
> > > > >   
> > > > >   Remove IPV6 knob, IPv6 now compiled-in automatically if
> > > > > support is found.
> > > > This still feels like a very bad idea.
> > > Could you please explain what exactly is very bad here?
> > We had that talk like a week or two ago. It means that if the
> > package
> > builder support IPv6 it will not work on a box without it, and if
> > the
> > package builder does not support IPv6, a box with IPv6 will not be
> > able
> > to use nginx with IPv6.
> Then you can go ahead and enable IPv6 on the package builder like you
> did the
> same for the third-party moz_zip module.
> 
> INET6 in FreeBSD's GENERIC kernel for years, I see no reason why
> shouldn't use it.
> 

Why do you continue to argue with multiple people who've expressed a
real-world need for this utterly trivial request to leave the IPV6 knob
in place?

In the real world I have builder machines which DO have IPv6 enabled,
which must be able to create packages that run on machines that do NOT
have IPv6 enabled.

-- Ian

> > 
> > > 
> > > > 
> > > > > 
> > > > >   Also, remove third-party modules:
> > > > >   o) udplog
> > > > >   o) statsd
> > > > >   
> > > > >   Enable third_party mod_zip module back by changing
> > > > > upstream.
> > > > >   
> > > > I think this is what breaks the build:
> > > > 
> > > > https://pkg.absolight.fr/data/11amd64-pkgng-default/20170426T18
> > > > 1224Z/logs/errors/nginx-1.12.0,2.log
> > > > 
> > > > cc -c -I/usr/local/include/luajit-2.0 -O2 -pipe  -
> > > > DLIBICONV_PLUG -fstack-protector -fno-strict-aliasing -I
> > > > /usr/local/include -DNDK_SET_VAR -Wno-write-strings
> > > > -DNDK_SET_VAR  -I src/core  -I src/event  -I
> > > > src/event/modules  -I src/os/unix  -I
> > > > /wrkdirs/usr/ports/www/nginx/work/nginx-push-stream-module-
> > > > 0.5.1/src  -I /wrkdirs/usr/ports/www/nginx/work/nginx-push-
> > > > stream-module-0.5.1/include  -I
> > > > /wrkdirs/usr/ports/www/nginx/work/ngx_devel_kit-0.3.0/objs  -I
> > > > objs/addon/ndk  -I /wrkdirs/usr/ports/www/nginx/work/lua-nginx-
> > > > module-0.10.8/src/api  -I /usr/local/include/libxml2  -I
> > > > /usr/local/include  -I objs  -I src/http  -I
> > > > src/http/modules  -I src/http/v2  -I src/http/modules/perl  -I
> > > > /wrkdirs/usr/ports/www/nginx/work/nchan-0.99.16/src  -I
> > > > /wrkdirs/usr/ports/www/nginx/work/ngx_devel_kit-0.3.0/src  -I
> > > > /wrkdirs/usr/ports/www/nginx/work/ngx_devel_kit-0.3.0/src  -I
> > > > /wrkdirs/usr/ports/www/nginx/work/ngx_devel_kit-0.3.0/objs  -I
> > > > objs/addon/ndk  -I /usr/local/include/luajit-2.0  -I
> > > > /wrkdirs/usr/ports/www/nginx/work/njs-753ebe6/nginx/../nxt  -I
> > > > /wrkdirs/usr/ports/www/nginx/work/njs-753ebe6/nginx/../njs  -I
> > > > src/mail  -I src/stream  -I
> > > > /wrkdirs/usr/ports/www/nginx/work/njs-753ebe6/nginx/../nxt  -I
> > > > /wrkdirs/usr/ports/www/nginx/work/njs-753ebe6/nginx/../njs  -o
> > > > objs/addon/mod_zip-
> > > > 74ef235/ngx_http_zip_module.o  /wrkdirs/usr/ports/www/nginx/wor
> > > > k/mod_zip-74ef235/ngx_http_zip_module.c
> > > > /wrkdirs/usr/ports/www/nginx/work/mod_zip-
> > > > 74ef235/ngx_http_zip_module.c:74:4: error: no member named
> > > > 'charset' in ''
> > > >           offsetof(ngx_http_zip_conf_t, charset),
> > > >           ^                             ~~~~~~~
> > > > /usr/include/stddef.h:65:32: note: expanded from macro
> > > > 'offsetof'
> > > > #define offsetof(type, member)  __offsetof(type, member)
> > > >                                 ^                ~~~~~~
> > > > /usr/include/sys/cdefs.h:477:34: note: expanded from macro
> > > > '__offsetof'
> > > > #define __offsetof(type, field)  __builtin_offsetof(type,
> > > > field)
> > > >                                  ^                        ~~~~~
> > > > 1 error generated.
> > > > *** Error code 1
> > > Need an explanation here why third-party mod_zip module has been
> > > enabled, cause by
> > > default all third-party modules should be switched off.
> > Because it was enabled by someone, me, for instance ?
> Would you mind to raise a PR for the same, thanks.
> In any case I can't reproduce it here on my FreeBSD 11.0-STABLE
> amd64.
>