svn commit: r438739 - head/editors/emacs-devel

Ian Lepore ian at freebsd.org
Tue Apr 18 18:16:25 UTC 2017


On Tue, 2017-04-18 at 18:30 +0200, Mathieu Arnold wrote:
> Le 17/04/2017 à 20:17, Joseph Mingrone a écrit :
> > 
> >   Also add MAKE_JOBS_UNSAFE=yes.
> >   
> This bit of the commit message is useless.  The fact that you added
> MAKE_JOBS_UNSAFE can be seen clearly in the commit diff below.  What
> cannot be seen and is now lost is why you are adding it.
> Does it have problems ordering targets ? Does it try to use a file
> before it is generated... ?
> People regularly go and try to fix these kind of things. If you do not
> explain they why, it is lost, and they have no idea where to begin their
> search.

The info doesn't have to be lost forever, it's not at all hard to
revert the change then re-commit with the proper message.

-- Ian


More information about the svn-ports-head mailing list