svn commit: r438383 - in head/audio: . schism schismtracker

[Emanuel Haupt]

Dmitry Marakasov <amdmi3 at amdmi3.ru> wrote:
> * Emanuel Haupt (ehaupt at FreeBSD.org) wrote:
> 
> > >> Author: ehaupt
> > >> Date: Wed Apr 12 16:30:34 2017
> > >> New Revision: 438383
> > >> URL: https://svnweb.freebsd.org/changeset/ports/438383
> > >>
> > >> Log:
> > >>   - Rename audio/schism for better naming
> > >>   - Add .desktop files for tracker and editor
> > >>   - Provide icons
> > >
> > > Nice! But it's missing MOVED entry. Also WWW should be updated to
> > > http://schismtracker.org/
> > 
> > See r438384. I've deliberately committed it (less than 10 seconds
> > later) separately  because this commit log contains information
> > that does not concern ports/MOVED (icons/dekstop).
> 
> There's no reason why commits to MOVED must not include other changes.
> Separating actual move and MOVED change is a bad approach IMO.

The reason why I prefer it separate is that ports/MOVED and the actual
port change is in a different section of the tree. If it is committed
together and someone is looking at the svn log of ports/MOVED he's
going to see all the unrelated rest (Add .desktop files...). I like it
that way, you like it the other way. Neither is "bad" it's just a
different style.