svn commit: r437953 - in head/lang/beignet: . files

Jan Beich jbeich at FreeBSD.org
Fri Apr 7 20:21:39 UTC 2017


Matthew Rezny <rezny at FreeBSD.org> writes:

>   - Enable OpenCL 2.0 on AMD64

Isn't this premature before 1.3.2 or bug 217635 fix?

> +USE_LDCONFIG=	${LOCALBASE}/lib/${PORTNAME}

Why do you need ldconfig hints for dlopen(3)? libcl.so embeds absolute
paths for libgbe.so and libgbeinterp.so + absolute path via ocl-icd
config in /usr/local/etc/OpenCL/vendors/intel-beignet.icd

Please, don't turn portlint into a cargo cult.

> +LLVMVER=	${MESA_LLVM_VER:U39}

Why not drop LLVMVER variable and use MESA_LLVM_VER directly?

  BUILD_DEPENDS=	clang${MESA_LLVM_VER}:devel/llvm${MESA_LLVM_VER} \
  [...]
  MESA_LLVM_VER?=	39


More information about the svn-ports-head mailing list