svn commit: r422939 - in head/cad/gmsh: . files

[John Marino]

On 9/29/2016 18:52, Joseph Mingrone wrote:
> Hi John,
>
> John Marino <freebsd.contact at marino.st> writes:
>> On 9/29/2016 14:15, Joseph Mingrone wrote:
>>> Author: jrm Date: Thu Sep 29 19:15:34 2016 New Revision: 422939
>>> URL: https://svnweb.freebsd.org/changeset/ports/422939
>
>>> Log: Update cad/gmsh to 2.13.2; fix knob issue; other changes
>
>>> - Remove MAKE_JOBS_UNSAFE=yes
>
>> I'm curious about this one.  Was this specifically addressed in the
>> release notes?  or in other words, how did you confirm this port is
>> now jobs safe?
>
> I looked at the commit log, but there was no mention of the reason
> why this was added.  I ran the build through 'poudriere testport' and
> looked over the output.  Should I be checking something else?
>

In my opinion, to remove MAKE_JOBS_UNSAFE, first the unsafe operation of 
the previous version has to be identified and then it has to be 
confirmed that the new version has explicitly fixed it.  If you don't 
have proof of the fix, then conservatively you have to assume it's still 
not jobs-safe.  A single positive build isn't enough to change the 
setting.  It could only show under a heavily loaded server, and only 
some times, for example, and your run didn't provide similar conditions.

It's unfortunate the commit log didn't detail the original problem.  I 
seem to recall also hitting jobs unsafe problems with this port and I 
would not be surprised if they come back now.

John


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus