svn commit: r422874 - in head: devel/efl net-mgmt/nsca-ng net-mgmt/zabbix3-server net-mgmt/zabbix32-server www/tomcat-native

[Mathieu Arnold]

Le 28/09/2016 à 16:38, John Marino a écrit :
> On 9/28/2016 09:35, Mathieu Arnold wrote:
>> Le 28/09/2016 à 16:31, John Marino a écrit :
>>> On 9/28/2016 08:47, Mathieu Arnold wrote:
>>>> Author: mat
>>>> Date: Wed Sep 28 13:47:53 2016
>>>> New Revision: 422874
>>>> URL: https://svnweb.freebsd.org/changeset/ports/422874
>>>>
>>>> Log:
>>>>   Also, you can't set SSL_DEFAULT, and don't give bad advices to
>>>> people,
>>>>   it should never be set directly, but always through
>>>> DEFAULT_VERSIONS.
>>>>
>>>
>>> fair point about setting though DEFAULT_VERSIONS, but it appears to me
>>> this is purely a semantic policy.  From looking at the code, there's
>>> no technical issue with setting SSL_DEFAULT instead.  It's just doing
>>> it before bsd.default-versions.mk can do exactly the same thing.
>>>
>>> I'm fine with this "just use DEFAULT_VERSIONS+=" policy but I did want
>>> to be pedantic that the other way caused no problem.  (and is actually
>>> more intuitive but that's neither here nor there)
>>
>> There. can. only. be. one. system-wide. default.
>>
>> Setting SSL_DEFAULT is the same as setting DEFAULT_VERSIONS in a port,
>> you don't do it, because then, it is not system wide.  What started this
>> is what I fixed in r422872, if you are running 9 with libressl, mysql
>> would not build because it would try to install openssl.
>
> Again, to be pedantic,
> I'm talking about /etc/make.conf.
> If "DEFAULT_SSL=openssl" is set the /etc/make.conf, it's system wide.
> It's defined in one spot.
>
> You fixed those issues correctly.  Those were setting in the ports
> makefile, which is not the same as setting in make.conf.
>
> Ok?  You agree?

Because there is one good way to set defaults, it is with DEFAULT_VERSIONS.

https://reviews.freebsd.org/D8060

-- 
Mathieu Arnold


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20160928/11e99f4a/attachment.sig>