svn commit: r422151 - head/devel/php70-APCu

[Bryan Drewery]

On 9/14/16 4:22 PM, Guido Falsi wrote:
> On 09/14/16 21:46, Mathieu Arnold wrote:
>> Le 14/09/2016 à 21:13, Guido Falsi a écrit :
>>> Author: madpilot
>>> Date: Wed Sep 14 19:13:07 2016
>>> New Revision: 422151
>>> URL: https://svnweb.freebsd.org/changeset/ports/422151
>>>
>>> Log:
>>>   Add PHP_DEFAULT=7.0 so that a package is build on the cluster with
>>>   default ports configuration.
>>>   
>>>   PR:		212684
>>>   Submitted by:	joshruehlig at gmail.com
>>>   Approved by:	Daniel Ylitalo <daniel at blodan.se> (maintainer)
>>>
>>
>> Please, revert this.
>>
>> We do not force PHP versions of modules/extensions, either you have the
>> right default version, and it will build and work, or you don't have the
>> right default version and it will be a two leg stool.
>>
> 
> The reason I did this is there are already other PHP modules doing this,
> so I thought it was ok.
> 
> While I understand what the problem is this is a leaf port and such a
> change causes no problems and allows the package to be built in the cluster.
> 
> Before reverting this I'd like to have an opinion from portmgr (CCed).
> 
> Meybe some cleaner way to allow php7 parts to be built on the cluster
> should be made available, although I don't know what that can be right now.
> 

It seems reasonable to me since it is NAMED php70-.  Setting the default
is done in python ports like this as well.

Wrapping an IGNORE in !PACKAGE_BUILDING seems ok to me too.

-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 496 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20160914/937086ab/attachment.sig>