svn commit: r422160 - in head: chinese/fortune french/fortune-mod-zarathoustra misc/fortune-mod-bible misc/fortune-mod-bofh misc/fortune-mod-culmea-culmilor misc/fortune-mod-epictetus misc/fortune-...

[John Marino]

On 9/14/2016 18:23, Steve Wills wrote:
> Hi,
>
> On 09/14/2016 18:49, John Marino wrote:
>> Only something that didn't review the commit would say that.  It is
>> cleaner and that's pretty much indisputable.
>
> Are you saying that fortune_strfile doesn't duplicate /usr/bin/strfile?
>

I'm saying look at the diff.
I'm also saying that my solutions works in 100% of the cases the 
old/reverted form does not.

The makefile is cleaner and more performant.
The duplication of a tiny utility for build purposes is a red herring.

to recap:
1) the fortune makefiles are a lot cleaner
2) it builds fortune ports in more (all) cases

It's just superior.
There's no technical basis for reverting it.

---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus