svn commit: r422100 - in head/www: . fabio fabio/files

[Vanilla Hsu]

Got it, thanks for your suggestion.

2016-09-14 14:44 GMT+08:00 Mathieu Arnold <mat at freebsd.org>:

> Le 14/09/2016 à 06:06, Vanilla I. Shu a écrit :
> > +GH_ACCOUNT=  eBay:DEFAULT
>
> You can drop the :DEFAULT, it is the, well, default.
>
> > +GH_PROJECT=  fabio
>
> You can remove this one, it is the default.
> > +USERS=               nobody
> > +GROUPS=              nobody
>
> I am pretty sure nothing should belong, or run, as nobody, and you
> should create a user for this.  As a side note, this user and group
> already exist on all FreeBSD installations and they do not need to be
> added here.
>
> > +do-build:
> > +     @${MKDIR} ${WRKSRC}/src/github.com/eBay/fabio
> > +
> > +.for src in .gitignore .travis.yml CHANGELOG.md Dockerfile LICENSE
> Makefile \
> > +     README.md Vagrantfile admin build cert config demo exit fabio.png \
> > +     fabio.properties listen.go listen_test.go main.go metrics proxy \
> > +     registry route routes.txt vendor
> > +     @${MV} ${WRKSRC}/${src} \
> > +             ${WRKSRC}/src/github.com/eBay/fabio
> > +.endfor
>
> All this, firstly, belong to the extract phase, and can be done better as:
>
> GH_SUBDIR=    src/github.com/eBay/fabio
>
> --
> Mathieu Arnold
>
>
>