svn commit: r423434 - head/security/openssl

[Bernard Spil]

On 2016-10-07 5:36, Joseph Mingrone wrote:
> Mathieu Arnold <mat at FreeBSD.org> writes:
> 
>> Le 06/10/2016 à 21:38, Bernard Spil a écrit :
>>> Author: brnrd
>>> Date: Thu Oct  6 19:38:48 2016
>>> New Revision: 423434
>>> URL: https://svnweb.freebsd.org/changeset/ports/423434
> 
>>> Log:
>>>   security/openssl: Fix ldconfig issue
> 
>>>     - OPT_USE= feature does not behave as expected
> 
>> I strongly disagree with that comment, the opt_USE works exactly as
>> expected, and as documented.
> 
> If I am understanding the documentation correctly
> 
> OPT_USE=	ldconfig=${PREFIX}/lib/blah/lib
> 
> should add ${PREFIX}/lib/blah/lib to 
> ${LOCALBASE}/libdata/ldconfig/blah.
> 
> I just tested and it is not creating
> ${LOCALBASE}/libdata/ldconfig/blah when OPT is on.
> 
> The code below does.
> 
> .if ${PORT_OPTIONS:MOPT}
> USE_LDCONFIG=	${PREFIX}/lib/blah/lib
> .endif

Hi Joseph,

That's another issue which is specific to using ${PREFIX} at this stage.
When I set
SHARED_USE=             ldconfig=${PREFIX}/lib/blah

$ make -VUSE_LDCONFIG
/lib/blah
as ${PREFIX} isn't set during options processing

I was just looking for the default behavior here. Setting SHARED_USE= 
ldconfig results in
$ make -VUSE_LDCONFIG
ldconfig

for lack of an `=' character in the SHARED_USE value. I have created 
D8166 that simply sets USE_FEATURE= yes when no `=' is present in 
OPT_USE= feature.

Cheers,

Bernard.