svn commit: r416200 - head/net/spoofer

Alexey Dokuchaev danfe at FreeBSD.org
Tue May 31 14:17:31 UTC 2016


On Tue, May 31, 2016 at 01:58:44PM +0000, Philippe Audeoud wrote:
> New Revision: 416200
> URL: https://svnweb.freebsd.org/changeset/ports/416200
> 
> Log:
>   - Fix indent
>   
>   Noticed by:	danfe

Thanks, but see below.

> [...]
> -GNU_CONFIGURE=		yes
> +GNU_CONFIGURE=	yes
>  CONFIGURE_ARGS+=	--disable-development

This is initial assignment, += is not warranted.

> -OPTIONS_DEFINE=		DOCS GUI
> +OPTIONS_DEFINE=	DOCS GUI
>  OPTIONS_DEFAULT=	GUI
> -OPTIONS_SUB=		yes
> +OPTIONS_SUB=	yes
>  
>  .include <bsd.port.options.mk>

Consider converting the block below to options helper knobs and get rid of
.include <bsd.port.options.mk>.

>  .if ${PORT_OPTIONS:MGUI}
> -USE_QT5=		buildtools_build qmake_build core network gui widgets
> -USE_GL+=		gl
> -USE_RC_SUBR=		${PORTNAME}
> +USE_QT5=	buildtools_build qmake_build core network gui widgets
> +USE_GL+=	gl
> +USE_RC_SUBR=	${PORTNAME}
>  .else
>  CONFIGURE_ARGS+=	--disable-manager
>  .endif
>  
>  do-install-DOCS-on:
> -	${MKDIR} ${STAGEDIR}${DOCSDIR}
> +${MKDIR} ${STAGEDIR}${DOCSDIR}

This one is wrong, ${MKDIR} is part of the recipe.

./danfe


More information about the svn-ports-head mailing list