svn commit: r416053 - head/Mk/Uses

Mathieu Arnold mat at FreeBSD.org
Sat May 28 19:54:42 UTC 2016


+--On 28 mai 2016 17:19:44 +0000 Kurt Jaeger <pi at FreeBSD.org> wrote:
| Log:
|   Mk/Uses/qmake.mk: add empty do-configure target

I'm going to pass on the commit message.

|  .if !target(do-configure) && ! ${qmake_ARGS:M_env}
| -_USES_configure+=	450:qmake-configure
| +do-configure: qmake-configure
| +	@${DO_NADA}
|  .endif

I should explain a bit more.

This goes against the Right Way Of Doing Things(c)(r)(tm).

To add a target to be run in the targets pipeline, you use _USES_xxx, you
never, ever, piggyback on an existing target, especially if you're not
using it.

So, please, back this out.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 949 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20160528/13f32ef3/attachment.sig>


More information about the svn-ports-head mailing list