svn commit: r414387 - head/x11/xvattr

[Alexey Dokuchaev]

On Sun, May 01, 2016 at 06:06:02AM +0000, Cy Schubert wrote:
> New Revision: 414387
> URL: https://svnweb.freebsd.org/changeset/ports/414387
> 
> Log:
>   Make fetchable again.
>   
>   Take maintainership of this port.
> 
> Modified:
>   head/x11/xvattr/Makefile
>   head/x11/xvattr/distinfo
> 
> Modified: head/x11/xvattr/Makefile
> ==============================================================================
> --- head/x11/xvattr/Makefile	Sun May  1 05:29:08 2016	(r414386)
> +++ head/x11/xvattr/Makefile	Sun May  1 06:06:02 2016	(r414387)
> @@ -5,14 +5,12 @@ PORTNAME=	xvattr
>  PORTVERSION=	1.3
>  PORTREVISION=	8
>  CATEGORIES=	x11
> -MASTER_SITES=	ftp://ftp.SpringDaemons.com/soft/ \
> -		http://www.dtek.chalmers.se/groups/dvd/dist/
> +MASTER_SITES=	http://xvattr.sourcearchive.com/downloads/1.3/

We usually do not hardcode version numbers in MASTER_SITES.  While it can
be beneficial to be able to copy-paste the URL with a mouse, having to
touch MASTER_SITES whenever version changes is considered stronger reason
to avoid this.

> +DISTFILES=	xvattr_1.3.orig.tar.gz

Why DISTFILES was used here instead of DISTNAME?  Also, it hardcodes the
PORTNAME and PORTVERSION which is definitely wrong in this case.

./danfe