svn commit: r417364 - head/Mk/Scripts

[Mathieu Arnold]

+--On 30 juin 2016 13:19:18 +0200 Baptiste Daroussin <bapt at FreeBSD.org>
wrote:
| On Thu, Jun 30, 2016 at 10:21:03AM +0200, Mathieu Arnold wrote:
|> 
|> 
|> +--On 30 juin 2016 07:41:09 +0200 Baptiste Daroussin <bapt at FreeBSD.org>
|> wrote:
|> | On Wed, Jun 29, 2016 at 04:33:52PM -0700, Bryan Drewery wrote:
|> |> On 6/23/2016 4:31 AM, Mathieu Arnold wrote:
|> |> > Author: mat
|> |> > Date: Thu Jun 23 11:31:15 2016
|> |> > New Revision: 417364
|> |> > URL: https://svnweb.freebsd.org/changeset/ports/417364
|> |> > 
|> |> > Log:
|> |> >   Extend the symlink checks to warn on absolute targets.
|> |> >   
|> |> >   Sponsored by:	Absolight
|> |> >   Differential Revision:	https://reviews.freebsd.org/D6930
|> |> 
|> |> Why? This seems like noise.
|> | 
|> | Quite true as it is I overlooked it.
|> | 
|> | To ease relocatable packages (to prepare sysroot for exemple) symlinks
|> | that points to file within the same package should be absolute links.
|> | 
|> | After looking at this patch again I think it should be reverted and
|> | replaced later by something that will check symlinks on the same plist
|> 
|> Mmmm, I can add a check to see if the target is in STAGEDIR and only emit
|> the warning if it is.
| 
| would definitly help

I did that in r417821 (now poudriere doesn't have any symlinks warnings)

I added a second warning if the symlink points to something that does't
exist anywhere, feel free to remove it if it is annoying too :-)

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 949 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20160630/fb63572f/attachment.sig>