svn commit: r417364 - head/Mk/Scripts

[Bryan Drewery]

On 6/23/2016 4:31 AM, Mathieu Arnold wrote:
> Author: mat
> Date: Thu Jun 23 11:31:15 2016
> New Revision: 417364
> URL: https://svnweb.freebsd.org/changeset/ports/417364
> 
> Log:
>   Extend the symlink checks to warn on absolute targets.
>   
>   Sponsored by:	Absolight
>   Differential Revision:	https://reviews.freebsd.org/D6930

Why? This seems like noise.

====> Running Q/A tests (stage-qa)
Warning: Bad symlink '/usr/local/share/poudriere/MANIFESTS' pointing to
an absolute pathname '/usr/local/share/freebsd/MANIFESTS'

Comes from:

${LN} -fs ${LOCALBASE}/share/freebsd/MANIFESTS \
    ${STAGEDIR}${DATADIR}/MANIFESTS

Now carefully note that DATADIR is based on PREFIX.

It's not safe to assume PREFIX == LOCALBASE.

So I cannot just create a relative symlink from DATADIR/MANIFESTS to
../../freebsd/MANIFESTS, because that assumes and forces that PREFIX ==
LOCALBASE.

By the way, I noticed this had been out for review.  Yes I missed that.
Still, I was surprised by this.

-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20160629/d36efca3/attachment.sig>