svn commit: r417374 - in head: Mk Mk/Uses lang/php55 lang/php56 lang/php70 www/redaxo

[Adam Weinberger]

> On 24 Jun, 2016, at 1:28, Mathieu Arnold <mat at FreeBSD.org> wrote:
> 
> 
> 
> +--On 23 juin 2016 16:37:36 -0600 Adam Weinberger <adamw at adamw.org> wrote:
> |> On 23 Jun, 2016, at 15:36, Mathieu Arnold <mat at FreeBSD.org> wrote:
> |> 
> |> +--On 23 juin 2016 13:46:41 -0600 Adam Weinberger <adamw at adamw.org>
> |> wrote:
> |> |> On 23 Jun, 2016, at 7:19, Mathieu Arnold <mat at FreeBSD.org> wrote:
> |> |> 
> |> |> Author: mat
> |> |> Date: Thu Jun 23 13:19:17 2016
> |> |> New Revision: 417374
> |> |> URL: https://svnweb.freebsd.org/changeset/ports/417374
> |> |> 
> |> |> Log:
> |> |>  Move bsd.php.mk to Uses/php.mk
> |> |> 
> |> |>  PR:		210323
> |> |>  Submitted by:	mat
> |> |>  Exp-run by:	antoine
> |> |>  Sponsored by:	Absolight
> |> |>  Differential Revision:	https://reviews.freebsd.org/D6867
> |> | 
> |> |> # If you are building PHP-based ports in poudriere(8) with ZTS
> |> |> # enabled, add WITH_MPM=event to /etc/make.conf to prevent build
> |> |> # failures.
> |> | 
> |> | Does USES=php still have the above bug? If not, are there plans to make
> |> | ZTS detection work without assuming that everybody has apache
> |> | installed?
> |> 
> |> I did not change a thing, I'm modernizing the framework, I'm changing how
> |> things are done, but not what the things being done do.
> |> 
> |> (Also, I have absolutely no idea what ZTS is, or what the difference
> |> between the different MPM are.)
> | 
> | ZTS is a threading model for PHP. For a long time, bsd.php.mk has made
> | the strange decision to use the output of 'httpd -V' (from apache) to
> | determine whether PHP was built with ZTS. It uses that to determine which
> | directory to put modules into.
> | 
> | The problem with that bizarre method is that if you don't have apache
> | installed, it puts modules into the wrong directory, and then all further
> | builds fail. In order to build PHP ports in poudriere, you have to trick
> | the system by using that WITH_MPM=event line.
> | 
> | There are a couple bugs open about it. 201193 and 207284 are both open
> | for it. php.mk should either put all PHP modules into one place (there's
> | really no point to making the module dir change), or figure out whether
> | PHP was built with ZTS by examining php.ini or the output of php-config.
> 
> I'll have a look at it, I'm refactoring USES=php right now[1].  Though, I'm
> more inclined to do baby steps, and not change what's in it.  The directory
> could easily be put in the php.conf file, it would solve all those
> problems, I think.
> 
> 1: https://reviews.freebsd.org/D6936

That definitely feels like the right place for it.

# Adam


-- 
Adam Weinberger
adamw at adamw.org
http://www.adamw.org