svn commit: r416393 - in head: deskutils/tomboy devel/gmake devel/ocaml-deriving-ocsigen/files games/0ad/files

[Guido Falsi]

On 06/05/16 20:31, Tijl Coosemans wrote:
> On Sun, 5 Jun 2016 17:59:48 +0200 Guido Falsi <madpilot at FreeBSD.org> wrote:
>> On 06/05/16 17:53, Tijl Coosemans wrote:
>>> On Sun, 5 Jun 2016 16:40:51 +0200 Guido Falsi <madpilot at FreeBSD.org> wrote:
>>>> On 06/05/16 16:35, Tijl Coosemans wrote:
>>>>>   - games/0ad: disable make jobs when building bundled Spidermonkey.
>>>>
>>>> Thanks for spotting this!
>>>
>>> Actually I don't fully understand the problem.  Something about the
>>> combination of phony double-colon rules and multiple jobs breaks things.
>>> I'm not entirely convinced it's a Makefile bug.  It could be a gmake bug,
>>> but I haven't managed to reproduce it in a small test Makefile.
>>>
>>> I figured out a way to work around the first case in the Spidermonkey
>>> Makefiles (see patch 3 in the PR), but not the second so I just disabled
>>> make jobs.
>>
>> Interesting.
>>
>> I'll try to check if I can fix it myself in the next days.
> 
> r416413 seems to fix this as well.  I'll leave it to you to double check
> this and revert the change.
> 

Most probably it does fix it. Going to check soon.

Thanks again!

-- 
Guido Falsi <madpilot at FreeBSD.org>