svn commit: r416248 - head/games/asteroid

[Jan Beich]

Rusmir Dusko <nemysis at FreeBSD.org> writes:

> --- head/games/asteroid/Makefile	Wed Jun  1 15:35:42 2016	(r416247)
> +++ head/games/asteroid/Makefile	Wed Jun  1 16:01:52 2016	(r416248)
> @@ -6,7 +6,7 @@ PORTVERSION=	1.2.1
>  PORTREVISION=	3
>  CATEGORIES=	games
>  
> -MAINTAINER=	ports at FreeBSD.org
> +MAINTAINER=	nemysis at FreeBSD.org
>  COMMENT=	Modern version of the arcade classic Asteroid
>  
>  LICENSE=	GPLv3
> @@ -14,12 +14,12 @@ LICENSE_FILE=	${WRKSRC}/COPYING
>  
>  USE_GITHUB=	yes
>  GH_ACCOUNT=	chazomaticus
> -GH_TAGNAME=	ffeb0fd
> +GH_TAGNAME=	64869df

Defining GH_TAGNAME is undesirable as it may lead to a situation where
the port is updated without affecting PORTVERSION or PORTREVISION like here.
Maybe switch to |git describe --tags| distfile style (see attached patch).

>  
>  USES=		cmake
>  USE_GL=		glut
>  USE_SDL=	mixer sdl
> -USE_GNOME=	gtk20
> +USE_GNOME=	gtk30

Dependency changes require at least PORTREVISION bump to facilitate
troubleshooting and for old tools than may not notice otherwise.

--
$ pkg version -t asteroid-1.2.1_3 asteroid-1.2.1.9
<

Index: games/asteroid/Makefile
===================================================================
--- games/asteroid/Makefile	(revision 416253)
+++ games/asteroid/Makefile	(working copy)
@@ -2,8 +2,8 @@
 # $FreeBSD$
 
 PORTNAME=	asteroid
-PORTVERSION=	1.2.1
-PORTREVISION=	3
+DISTVERSION=	1.2.1-9
+DISTVERSIONSUFFIX=	-g64869df
 CATEGORIES=	games
 
 MAINTAINER=	nemysis at FreeBSD.org
@@ -14,7 +14,6 @@ LICENSE_FILE=	${WRKSRC}/COPYING
 
 USE_GITHUB=	yes
 GH_ACCOUNT=	chazomaticus
-GH_TAGNAME=	64869df
 
 USES=		cmake
 USE_GL=		glut
Index: games/asteroid/distinfo
===================================================================
--- games/asteroid/distinfo	(revision 416253)
+++ games/asteroid/distinfo	(working copy)
@@ -1,2 +1,2 @@
-SHA256 (chazomaticus-asteroid-1.2.1-64869df_GH0.tar.gz) = 09646285433d1266f5b2c3f1f35b05c39a3314414c05bdb3bd31ae224d029d05
-SIZE (chazomaticus-asteroid-1.2.1-64869df_GH0.tar.gz) = 307544
+SHA256 (chazomaticus-asteroid-1.2.1-9-g64869df_GH0.tar.gz) = 9859e7283ccd243e01340cfc24fdb3384d4af95fa6a5d5c7bbf9a0fb9e557d33
+SIZE (chazomaticus-asteroid-1.2.1-9-g64869df_GH0.tar.gz) = 307587
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 602 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20160601/09f7bb2b/attachment.sig>