svn commit: r407237 - head/mail/imaputils

[Alexey Dokuchaev]

On Tue, Jan 26, 2016 at 04:09:57PM +0100, Mathieu Arnold wrote:
> +--On 26 janvier 2016 14:10:38 +0000 Alexey Dokuchaev <danfe at FreeBSD.org>
> wrote:
> | On Mon, Jan 25, 2016 at 07:10:39PM +0000, Kurt Jaeger wrote:
> |> New Revision: 407237
> |> URL: https://svnweb.freebsd.org/changeset/ports/407237
> |> 
> |> Log:
> |>   mail/imaputils: remove redundant GH_PROJECT entry
> |>   
> |>   PR:		206540
> |>   Submitted by:	mat
> | 
> | This commit has nothing to do with that PR, and that PR was not submitted
> | by mat at .  Please be more careful with attribution, it confuses people when
> | done wrong.
> 
> Well, the "submitted by" is not related to who submitted the PR, it is
> related to who submitted the change.  For example, one person can create a
> PR without a patch and the committer fixes it, then the "submitted by" is
> empty, or someone else adds the patch to the PR, then the "submitted by"
> contains the person that sent the patch.

Right, there are few possible combinations like that; usually I try to give
attribution in a way that makes the most sense if read naturally (top to
bottom).  For example, for the actuall patch submitted by foo, with a
related PR (submitted by someone else) it's probably better to put
"Submitted by" line first, and PR line after.  Or clarify whose contribution
is whose by putting it next to name/PR in parentheses or something.

./danfe