svn commit: r405766 - head/print/abcm2ps

Alexey Dokuchaev danfe at FreeBSD.org
Wed Jan 13 04:02:25 UTC 2016


On Mon, Jan 11, 2016 at 08:26:34AM +0000, Alexey Dokuchaev wrote:
> On Mon, Jan 11, 2016 at 07:21:19AM +0000, Marcelo Araujo wrote:
> > New Revision: 405766
> > URL: https://svnweb.freebsd.org/changeset/ports/405766
> > 
> > Log:
> >   - Update to 8.10.0.
> >   - USE_GCC yes.
> 
> There are several problems with this commit.  On the surface, it does not
> explain the reason for USE_GCC.  Secondly, even with USE_GCC=yes it still
> does no build, due to "CC = gcc" line in the $wrksrc/Makefile.  Also, the

Sorry for confusion: apparently it builds with USE_GCC unless `lang/gcc48'
port is installed, which satisfies "depends on executable: gcc48 - found",
but doesn't install unversioned symlink (available since r402352 2015-11-24
in `lang/gcc' itself -- older packages would also fail).

That said, pulling GCC just because it provides `gcc' command looks bogus.

> port does not uphold CFLAGS (and CC, obviously).
> 
> Consider the following pseudo-patch:
> 
>   -USE_GCC=       yes
>   +MAKE_ARGS=     CC="${CC}" CFLAGS="${CFLAGS}"

If you prefer, I can send a real patch.

./danfe


More information about the svn-ports-head mailing list