svn commit: r429401 - head/x11/lxqt-l10n

[Olivier Duchateau]

On Wed, 28 Dec 2016 14:31:19 +0100
Mathieu Arnold <mat at FreeBSD.org> wrote:

> Le 28/12/2016 à 09:59, Olivier Duchateau a écrit :
> > On Mon, 26 Dec 2016 16:25:52 +0100
> > Mathieu Arnold <mat at FreeBSD.org> wrote:
> >
> >> Le 25/12/2016 à 08:55, Olivier Duchateau a écrit :
> >>> Author: olivierd
> >>> Date: Sun Dec 25 07:55:17 2016
> >>> New Revision: 429401
> >>> URL: https://svnweb.freebsd.org/changeset/ports/429401
> >>>
> >>> Log:
> >>>   Remove USES= metaport, otherwise fetch target is not functional  
> >> Mmmm, I don't understand, why would a port that does not build or
> >> install anything need to fetch something for ?
> > In fact, since the 0.11.0 LXQt release, upstream decided to provide translation files in separated tarball (lxqt-l10n). It's nonsense to add this such raw port (because some piece of LXQt are not yet imported), and I think, users, which want to install graphics/lximage-qt don't want others translations. That's why we have decided to split tarball.
> >
> > Furthermore, I think it's stupid to duplicate distinfo for each *-l10n related ports, so we need to centralize metadata somewhere.
> 
> Keeping the same distinfo file in one place is a good idea.
> Now, I still do not understand why *this* ports needs to be able to
> fetch it. Any other port that needs this distinfo can, and will.

I made a mistake, due to parallel use of USES= metaport and lxqt in Makefile.
I think, this patch [1] is better (tested in new poudriere environment).

[1] https://people.freebsd.org/~olivierd/patches/lxqt-l10n.diff

> 
> -- 
> Mathieu Arnold
> 
> 


-- 
Olivier Duchateau <olivierd at freebsd.org>