svn commit: r428858 - head/ftp/curl

[Sunpoet Po-Chuan Hsieh]

On Tue, Dec 20, 2016 at 12:53 AM, Adam Weinberger <adamw at adamw.org> wrote:

> > On 18 Dec, 2016, at 8:20, Sunpoet Po-Chuan Hsieh <sunpoet at FreeBSD.org>
> wrote:
> >
> > Author: sunpoet
> > Date: Sun Dec 18 15:20:50 2016
> > New Revision: 428858
> > URL: https://svnweb.freebsd.org/changeset/ports/428858
> >
> > Log:
> >  - Change HTTP2 dependency from www/nghttp2 to www/libnghttp2
> >  - Enable HTTP2 option by default
> >  - Bump PORTREVISION for dependency and package change
> >
> > Modified:
> >  head/ftp/curl/Makefile
> >
> > Modified: head/ftp/curl/Makefile
> > ============================================================
> ==================
> > --- head/ftp/curl/Makefile    Sun Dec 18 15:20:42 2016        (r428857)
> > +++ head/ftp/curl/Makefile    Sun Dec 18 15:20:50 2016        (r428858)
> > @@ -3,7 +3,7 @@
> >
> > -HTTP2_BUILD_DEPENDS= nghttp2>=1.0.0:www/nghttp2
> > -HTTP2_CONFIGURE_WITH=        nghttp2
> > -HTTP2_LIB_DEPENDS=   libnghttp2.so:www/nghttp2
> > -HTTP2_RUN_DEPENDS=   nghttp2>=1.0.0:www/nghttp2
> > +HTTP2_BUILD_DEPENDS= libnghttp2>=1.0.0:www/libnghttp2
> > +HTTP2_CONFIGURE_WITH=        libnghttp2
> > +HTTP2_LIB_DEPENDS=   libnghttp2.so:www/libnghttp2
> > +HTTP2_RUN_DEPENDS=   libnghttp2>=1.0.0:www/libnghttp2
>
> Hi Sunpoet,
>
> Having BUILD, RUN, and LIB depends on the same port looks odd; shouldn't
> just LIB_DEPENDS be sufficient? www/mod_http2-devel does it too.
>
>
Hello,

Good catch!
LIB_DEPENDS is required and {BUILD,RUN}_DEPENDS were added for version
requirement.
In fact, RUN_DEPENDS is not necessary. If required version was not
installed, it will be blocked by BUILD_DEPENDS.
Furthermore, BUILD_DEPENDS can also be removed here as libnghttp2 was born
to be 1.0.0+.

I'll update it later. Thanks!

Regards,
sunpoet

# Adam
>
>
> --
> Adam Weinberger
> adamw at adamw.org
> https://www.adamw.org
>
>