svn commit: r428845 - in head/devel: . py-XStatic py-XStatic-Angular py-XStatic-Angular-Bootstrap py-XStatic-Angular-FileUpload py-XStatic-Angular-Gettext py-XStatic-Angular-Schema-Form py-XStatic-...

[Mathieu Arnold]

Le 18/12/2016 à 14:52, Roman Bogorodskiy a écrit :
>   Mathieu Arnold wrote:
>
>> Le 18/12/2016 à 12:36, Roman Bogorodskiy a écrit :
>>> +COMMENT=	Xstatic-angular-bootstrap
>>>
>>> Added: head/devel/py-XStatic-Angular-Bootstrap/pkg-descr
>>> ==============================================================================
>>> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
>>> +++ head/devel/py-XStatic-Angular-Bootstrap/pkg-descr	Sun Dec 18 11:36:26 2016	(r428845)
>>> @@ -0,0 +1,3 @@
>>> +XStatic-Angular-Bootstrap
>>> +
>>> +WWW: http://pypi.python.org/pypi/XStatic-Angular-Bootstrap
>>> +COMMENT=	Angular-fileupload 12.0.4 (xstatic packaging standard)
>>>
>>> Added: head/devel/py-XStatic-Angular-FileUpload/pkg-descr
>>> ==============================================================================
>>> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
>>> +++ head/devel/py-XStatic-Angular-FileUpload/pkg-descr	Sun Dec 18 11:36:26 2016	(r428845)
>>> @@ -0,0 +1,3 @@
>>> +Angular-FileUpload 12.0.4 (XStatic packaging standard)
>>> +
>>> +WWW: http://pypi.python.org/pypi/XStatic-Angular-FileUpload
>> ...
>>
>> I understand those were mechanically created, but all the COMMENT[1] and
>> pkg-descr[2] files fall very short of our requirements.
>>
>> 1:
>> https://www.freebsd.org/doc/en/books/porters-handbook/makefile-comment.html
>>
>> 2: https://www.freebsd.org/doc/en/books/porters-handbook/porting-desc.html
> This is generally an information obtained from the corresponding Python
> packages. E.g. for XStatic-Angular-FileUpload we only have:

Let me quote one of the rules for COMMENT:

2) Do not include the package name or version number of software.

The fact that python does not enforce rules on their packages does not
mean we do not.

> We probably can add README contents to pkg-descr (I'm not sure it brings
> a lot of value though, it looks likes it's more or less common for these
> packages with only package name changed), but I'm not sure how can we
> improve COMMENT.

Please read the handbook links I gave you. COMMENT is a short, one line,
description of the software. pkg-descr is a longer description, it
should tell me what does, what it is, why it is usefull.
Especially, I should not have to go to the web site to understand those
things.


-- 
Mathieu Arnold


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20161218/a6a86a7c/attachment.sig>