svn commit: r428763 - in head/audio/fluidsynth: . files

[Mathieu Arnold]

Le 17/12/2016 à 17:38, Thomas Zander a écrit :
> On 17 December 2016 at 14:50, Mathieu Arnold <mat at freebsd.org> wrote:
>> Le 17/12/2016 à 14:41, Thomas Zander a écrit :
>>> Modified: head/audio/fluidsynth/Makefile
>>> ==============================================================================
>>> --- head/audio/fluidsynth/Makefile    Sat Dec 17 13:26:05 2016        (r428762)
>>> +++ head/audio/fluidsynth/Makefile    Sat Dec 17 13:41:32 2016        (r428763)
>>> @@ -13,7 +13,7 @@ COMMENT=    Real-time software synthesizer
>>>  LICENSE=     LGPL20
>>>  LICENSE_FILE=        ${WRKSRC}/COPYING
>>>
>>> -OPTIONS_DEFINE=      JACK ALSA DBUS LADSPA LASH PORTAUDIO PULSEAUDIO SNDFILE
>>> +OPTIONS_DEFINE=      JACK ALSA DBUS LADSPA LASH PORTAUDIO PULSEAUDIO SNDFILE SNDIO
>>>  OPTIONS_DEFAULT=     JACK
>> This is missing a PORTREVISION bump.
> Since when? The new SNDIO knob is disabled by default and the default
> package remains unchanged.

First, because, well, it is the rule[1]. You changed the options list,
so the package can change, so it must be bumped.
Second, because if I had built this port before you added the option,
and I had sndio installed, it would be linked with it but there would
not be a dependency recorded. But if I build it after this option is
added, it is not liked with SNDIO any more. Which makes a different
package, which is a big reason for bumping PORTREVISION.


>>> +SNDIO_LIB_DEPENDS=   libsndio.so:audio/sndio
>>> +SNDIO_CMAKE_OFF=     -Denable-sndio:BOOL=FALSE
>> I guess this should probably be:
>>
>> SNDIO_CMAKE_BOOL=    enable-sndio
> At the moment, fluidsynth handles all CMAKE bool switches in the 'old'
> fashion. We should update all of them, but I'd like to confirm that it
> still builds.

1:
https://www.freebsd.org/doc/en/books/porters-handbook/makefile-naming.html#makefile-portrevision


-- 
Mathieu Arnold


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20161217/edf50262/attachment.sig>