svn commit: r428154 - head/www/py-formalchemy

[René Ladan]

On 09-12-2016 05:09, Kubilay Kocak wrote:
> On 9/12/2016 7:12 AM, Rene Ladan wrote:
>>  PORTNAME=	formalchemy
>> -PORTVERSION=	1.3.3
>> -PORTREVISION=	2
>> +PORTVERSION=	1.5.1
> PyPI (CHEESESHOP) has 1.5.5
OK
> https://pypi.python.org/pypi/FormAlchemy
>
>>  CATEGORIES=	www python
>> -MASTER_SITES=	GOOGLE_CODE
>> +#MASTER_SITES=	https://github.com/FormAlchemy/formalchemy
> This can be removed (but switch this to CHEESESHOP instead given it has
> a later version)
Yeah, the commented out line crept in.
>>  PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
>>  DISTNAME=	FormAlchemy-${DISTVERSION}
>>  
>> @@ -14,11 +13,11 @@ COMMENT=	Toolkit for creating HTML form 
>>  
>>  LICENSE=	MIT
> There is a LICENSE_FILE (COPYRIGHT.TXT) in WKRSRC (both PyPI and
> Github), please add it when one exists there.
Sure, but I didn't touch this part...
>>  
>> -BROKEN=		Unfetchable (google code has gone away)
>> -DEPRECATED=	Broken, depends on expired py-sqlalchemy06
>> -EXPIRATION_DATE=	2016-12-08
>> +USE_GITHUB=	yes
>> +GH_ACCOUNT=	FormAlchemy
>> +GH_TAGNAME=	v${PORTVERSION}
> Use DISTVERSIONPREFIX=v instead of this (when using USE_GITHUB) and tags
> begin with 'v'.
Indeed, DISTVERSIONPREFIX is more generic, but GH_TAGNAME happened to
turn up earlier when looking to fix the port.
I should somehow remember this...
>>  
>> -BUILD_DEPENDS=	${PYTHON_PKGNAMEPREFIX}sqlalchemy06>=0.4.5:databases/py-sqlalchemy06 \
>> +BUILD_DEPENDS=	${PYTHON_PKGNAMEPREFIX}sqlalchemy10>=0.4.5:databases/py-sqlalchemy10 \
>>  		${PYTHON_PKGNAMEPREFIX}Tempita>=0.4:textproc/py-Tempita \
>>  		${PYTHON_PKGNAMEPREFIX}webhelpers>=0.6.4:www/py-webhelpers
> None of these are BUILD_DEPENDS (ie; setup.py:setup_requires) [1]
>
>>  RUN_DEPENDS:=	${BUILD_DEPENDS}
> * They are all RUN_DEPENDS (ie; setup.py:install_requires) [1]
> * MarkupSafe and six are missing from RUN_DEPENDS [1]
>
> [1] setup.py: install_requires=['SQLAlchemy', 'Tempita', 'WebHelpers2',
> 'WebOb', 'MarkupSafe', 'six'],
>
> See also: https://github.com/FormAlchemy/formalchemy/issues/69 as a
> backported commit may be required.
>
All the above was unmodified by the update, which was primarily done to
save the port from removal because it had an expired dependency and
mastersite.

Feel free to fix, or send in a PR.

René