svn commit: r420830 - in head/databases: . neo4j neo4j/files

[Chris Rees]

On 25 August 2016 09:47:07 BST, Mathieu Arnold <mat at FreeBSD.org> wrote:
>
>
>+--On 25 août 2016 02:19:15 +0000 Chris Rees <crees at FreeBSD.org> wrote:
>| +post-patch:
>| +	${REINPLACE_CMD} ${_SUB_LIST_TEMP} ${WRKSRC}/bin/neo4j-shared.sh \
>| +					${WRKSRC}/conf/neo4j.conf
>
>_SUB_LIST_TEMP is an undocumented *internal* framework variable.  It
>should
>*never* be used in a port's Makefile.
>With the amount of things I'm rewriting, it may disapear any day, and I
>will not hunt down the ports that use it where they should not.

I must say I had a reservation about using it, although I think I've seen this done before.  I think this should be exposed as ${SUB_SED_COMMAND} or something because it's useful.

Is there a mechanism for having patchfiles as SUB_FILES?

Chris
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.