svn commit: r396689 - in head/mail: cyrus-imapd23 cyrus-imapd24 cyrus-imapd25

[Hajimu UMEMOTO]

Hi,

>>>>> On Sat, 12 Sep 2015 16:51:54 +0200
>>>>> John Marino <freebsd.contact at marino.st> said:

> mat> | It seems your changes have many reasons.  It is hard to inspect
> mat> | whether it becomes equivalent to the one I intended.  Could you back
> mat> | all of your changes out, then separate every change reason and send
> mat> | your proposed diffs to me.
> 
> mat> With respect, no.  The thing that you wanted, that is, the man pages
> mat> definitions in the Makefie are back where they were.  All the other changes
> mat> are things the framework was already doing and that you were duplicating.
> 
> Then, I'll back them out by myself, sigh.  It is hard to inspect
> whether it becomes equivalent to the one I intended.  You could make
> me be disappointed at your effort.

freebsd.contact> I think this would be an example of bad citizenship.  You have no reason
freebsd.contact> to think Matt's commits are wrong.  Unless you have some evidence they
freebsd.contact> are, you should assume they are correct.  That also gives you lots and
freebsd.contact> lots of time to go through the changes at your pace.

freebsd.contact> I really don't want to see good changes backed out for bad code, which
freebsd.contact> is what it is being described as.  Does poudriere pass QA checks or not?
freebsd.contact>  If it does, then the port is working as intended, right?

Again, it is hard to inspect whether it becomes equivalent to the one
I intended.  The commit was done, violently.  Isn't it enough reason
for you?  At least, it seems different from something I intend in
DOCS.

Sincerely,

--
Hajimu UMEMOTO
ume at mahoroba.org  ume at FreeBSD.org
http://www.mahoroba.org/~ume/