svn commit: r399543 - in head/net: . openbsc openbsc/files

[Jan Beich]

Kurt Jaeger <pi at FreeBSD.org> writes:

> +USES=		autoreconf compiler:c11 gmake pkgconfig

USES=autoreconf often wants INSTALL_TARGET=install-strip which is a
standard automake target.

> +GNU_CONFIGURE=yes

Missing indentation between = and the value?

> +AUTOMAKE_ARGS=	--gnu --add-missing --copy

USE_AUTOTOOLS vestige?

> +CONFIGURE_ARGS+=	CFLAGS="-I${LOCALBASE}/include"

This overrides local CFLAGS, even defaults provided by sys.mk.
Ironically, ports-mgmt/portlint only complains about _ENV not _ARGS but
the rationale applies to both.

  WARN: Makefile: CFLAGS/CXXFLAGS are not needed in CONFIGURE_ENV as they are already added there in bsd.port.mk.
  WARN: Makefile: Consider passing include paths to configure via the CPPFLAGS macro (i.e. CPPFLAGS+=-I...)
  FATAL: Makefile: CFLAGS are clobbered in CONFIGURE_ENV.  Alter CFLAGS in the Makefile with CFLAGS+=... instead

> +OPTIONS_DEFAULT=

Why empty?

> +SQLITE_LIB_DEPENDS=	libsqlite.so:${PORTSDIR}/databases/sqlite3

How does one disable SQLITE if libsqlite3.so is already installed?

> +post-patch:
> +	${REINPLACE_CMD} -e 's|pkgconfigdir.*|pkgconfigdir = ${PREFIX}/libdata/pkgconfig|g' \
> +		${WRKSRC}/Makefile.am

Why not the following?

  USES = pathfix
  PATHFIX_MAKEFILEIN = Makefile.am

> ++++ include/openbsc/mgcp.h
> +@@ -31,6 +31,11 @@
> + 
> + #include <arpa/inet.h>
> + 
> ++#ifdef __FreeBSD__
> ++#include <sys/socket.h>
> ++#include <netinet/in.h>
> ++#endif

Why include only *some* POSIX headers conditionally?

> ++++ include/openbsc/rtp.h
> +@@ -10,6 +10,12 @@
> + #  define __BYTE_ORDER __DARWIN_BYTE_ORDER
> + #  define __LITTLE_ENDIAN __DARWIN_LITTLE_ENDIAN
> + #  define __BIG_ENDIAN __DARWIN_BIG_ENDIAN
> ++# elif defined(__FreeBSD__)
> ++#  if __FreeBSD_version < 1000000
> ++#   include <machine/endian.h>
> ++#  else
> ++#   include <x86/endian.h>
> ++#  endif

These headers aren't supposed to be included directly, see byteorder(9).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 602 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20151017/0dda2149/attachment.bin>