svn commit: r398821 - head/security/maia

[Baptiste Daroussin]

On Thu, Oct 08, 2015 at 01:19:42PM +0000, Dmitry Marakasov wrote:
> Author: amdmi3
> Date: Thu Oct  8 13:19:42 2015
> New Revision: 398821
> URL: https://svnweb.freebsd.org/changeset/ports/398821
> 
> Log:
>   - Move file owner handling to plist, fix stage as non-root
>   
>   PR:		203287
>   Submitted by:	amdmi3
>   Approved by:	maintainer timeout (ek at purplehat.org, 2 weeks)
> 
> Modified:
>   head/security/maia/Makefile
>   head/security/maia/pkg-plist
> 
> Modified: head/security/maia/Makefile
> ==============================================================================
> --- head/security/maia/Makefile	Thu Oct  8 12:56:37 2015	(r398820)
> +++ head/security/maia/Makefile	Thu Oct  8 13:19:42 2015	(r398821)
> @@ -338,7 +338,6 @@ post-patch:
>  do-install:
>  	${MKDIR} ${STAGEDIR}${WWWDIR}
>  	@cd ${WRKSRC}/php && ${COPYTREE_SHARE} . ${STAGEDIR}${WWWDIR}
> -	${CHOWN} -R ${WWWOWN}:${WWWGRP} ${STAGEDIR}${WWWDIR}/
>  	${LN} -s ${PREFIX}/share/smarty ${STAGEDIR}${WWWDIR}/libs/Smarty
>  	${MKDIR} -p ${STAGEDIR}${DATADIR}
>  	@cd ${WRKSRC}/scripts && ${COPYTREE_SHARE} . ${STAGEDIR}${DATADIR}/scripts
> @@ -350,11 +349,10 @@ do-install:
>  	${INSTALL} -m 640 ${WRKSRC}/maiad.conf.dist ${STAGEDIR}${ETCDIR}/maiad.conf.dist
>  	${INSTALL} -m 640 ${WRKSRC}/maia.conf.dist ${STAGEDIR}${ETCDIR}/maia.conf.dist
>  
> -.if ${PORT_OPTIONS:MDOCS}
> +do-install-DOCS-on:
>  	${MKDIR} ${STAGEDIR}${DOCSDIR}
>  .for i in ${DOCS}
>  	${INSTALL_DATA} ${WRKSRC}/${i} ${STAGEDIR}${DOCSDIR}
>  .endfor
> -.endif
>  
>  .include <bsd.port.post.mk>
> 
> Modified: head/security/maia/pkg-plist
> ==============================================================================
> --- head/security/maia/pkg-plist	Thu Oct  8 12:56:37 2015	(r398820)
> +++ head/security/maia/pkg-plist	Thu Oct  8 13:19:42 2015	(r398821)
> @@ -40,6 +40,8 @@ sbin/maiad
>  %%DATADIR%%/scripts/send-quarantine-reminders.pl
>  %%DATADIR%%/scripts/stats-snapshot.pl
>  @mode
> + at owner %%WWWOWN%%
> + at group %%WWWGRP%%

There is absolutly no reason those files belongs to those users only directories
(like cache directories) and files that the app expect to be able to modified
when run should be own by such user, otherwise everything should belong to
root/wheel: aka the default

Best regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20151008/440dc5cd/attachment.bin>