svn commit: r381524 - head/multimedia/v4l-utils/files

[Koop Mast]

On 18-3-2015 6:54, Oliver Lehmann wrote:
> Author: oliver
> Date: Wed Mar 18 05:54:28 2015
> New Revision: 381524
> URL: https://svnweb.freebsd.org/changeset/ports/381524
> QAT: https://qat.redports.org/buildarchive/r381524/
>
> Log:
>   Fix handling of getting and setting v4l2 controls.
>   The unpatched implementation depends on a Linux specific behaviour of getsubopt(3):
>   
>   > If the first suboption in optionp is recognized, getsubopt() returns
>   > the index of the matching suboption element  in tokens. Otherwise, -1
>   > is returned and *valuep is the entire name[=value] string.
>   
>   The "Otherwise..." part is implemented differently on FreeBSD. The file gets now
>   patched to use a local and reduced implementation of getsubopt(3) to fix this
>   
>   Approved by:	nox
>
> Modified:
>   head/multimedia/v4l-utils/files/patch-v4l2-ctl__v4l2-ctl.cpp
>

Hi, I'm currently working on updating libv4l to 1.6.3. And I noticed
that there are more usage of the getsubopt() function in the following
files:

utils/v4l2-ctl/v4l2-ctl-common.cpp utils/v4l2-ctl/ivtv-ctl.c
utils/v4l2-ctl/v4l2-ctl.cpp utils/v4l2-ctl/cx18-ctl.c utils/v4l2-
dbg/v4l2-dbg.cpp utils/rds-ctl/rds-ctl.cpp

I was wondering if you know or can check, if the same fix is also needed
for these files. Or that it is sufficiant to forward patch this patch to
the new libv4l. The patch for the update to 1.6.3 is
https://reviews.freebsd.org/D1482 .

-Koop