svn commit: r382799 - head/mail/rainloop

[Alexey Dokuchaev]

On Tue, Mar 31, 2015 at 09:51:19AM +0200, Kurt Jaeger wrote:
> > On Tue, Mar 31, 2015 at 07:33:56AM +0000, Kurt Jaeger wrote:
> > > New Revision: 382799
> > > URL: https://svnweb.freebsd.org/changeset/ports/382799
> > > 
> > > Log:
> > >   mail/rainloop: Add an OPTIONS_DEFAULT
> > 
> > May I ask, why MYSQL was preferred over SQLITE?
> 
> That's what the submitter provided.

Submitter might provide whatever they want.  It is the jobs of the committer
to verify and assess suggested changes, ensure they are indeed warranted,
adhere to out practices and quality standards, and *adequately explain* them
in the commit log.  A good rule of thumb is that commit log should 30% talk
about _what_ was changed, with remaining 70% devoted to _why_ it was made.

I know people are often get bored of writing long commit logs, but perhaps
100%:0% ratio in case of not-so-perfectly obvious change (like this one) is
way off the course.

./danfe