svn commit: r382595 - head/net/hostapd

John Marino freebsd.contact at marino.st
Sun Mar 29 12:29:31 UTC 2015


On 3/29/2015 15:20, Mathieu Arnold wrote:
> +--On 29 mars 2015 12:15:41 +0000 John Marino <marino at FreeBSD.org> wrote:
> | +OPTIONS_DEFINE=	PORTS_SSL
> | +
> | +PORTS_SSL_DESC= Build with OpenSSL from ports (instead of base system)
> | +
> | +.include <bsd.port.options.mk>
> | +
> | +.if ${PORT_OPTIONS:MPORTS_SSL}
> | +.if !defined(WITH_OPENSSL_PORT)
> | +IGNORE=		the PORTS_SSL option not allowed when WITH_OPENSSL_PORT is not
> | set +.endif
> | +CONFIGURE_ARGS+= --with-ssl-dir=${PREFIX}
> | +.else
> | +.if defined(WITH_OPENSSL_PORT)
> | +IGNORE=		the PORTS_SSL option is required when WITH_OPENSSL_PORT is set
> | +.endif
> | +.endif
> 
> That seems way overly complicated, why not just do:
> 
> .if defined(WITH_OPENSSL_PORT)
> CONFIGURE_ARGS+= --with-ssl-dir=${PREFIX}
> .endif


I assume the maintainer wants to preserve the possibility to not include
openssl capability at all...  (neither port nor base)

John


More information about the svn-ports-head mailing list