svn commit: r382355 - head/graphics/entangle

[Adam Weinberger]

Copying in Ben here.

If itstool is in fact just a build-time dependency, some of the patterns you have available are

RUN_DEPENDS:=	${BUILD_DEPENDS}
BUILD_DEPENDS+=	...

or

RUN_DEPENDS:=	${BUILD_DEPENDS:Nitstool*}

or

BUILD_DEPENDS:=	${RUN_DEPENDS} itstool:...

Though, as Alexey noted, that last one just looks weird.

# Adam


-- 
Adam Weinberger
adamw at adamw.org
http://www.adamw.org

> On 26 Mar, 2015, at 19:41, Alexey Dokuchaev <danfe at FreeBSD.org> wrote:
> 
> On Thu, Mar 26, 2015 at 11:30:52PM +0000, Adam Weinberger wrote:
>> New Revision: 382355
>> URL: https://svnweb.freebsd.org/changeset/ports/382355
>> QAT: https://qat.redports.org/buildarchive/r382355/
>> 
>> Log:
>>  Update graphics/entangle to 0.7.0, and assign maintainership to
>>  submitter (Ben Woods).
> 
> Nice, I've been waiting for a while to someone to grab this from me.  Having
> to install gtk3 everytime I was working on an update was a PITA.
> 
>> -BUILD_DEPENDS=	${LOCALBASE}/share/icons/mate/scalable/devices/camera-photo-symbolic.svg:${PORTSDIR}/x11-themes/mate-icon-theme
>> +BUILD_DEPENDS=	${LOCALBASE}/share/icons/mate/scalable/devices/camera-photo-symbolic.svg:${PORTSDIR}/x11-themes/mate-icon-theme \
>> +		itstool:${PORTSDIR}/textproc/itstool
>> LIB_DEPENDS=	libgphoto2.so:${PORTSDIR}/graphics/libgphoto2 \
>> 		libdbus-glib-1.so:${PORTSDIR}/devel/dbus-glib \
>> 		liblcms2.so:${PORTSDIR}/graphics/lcms2 \
>> @@ -20,10 +21,13 @@ LIB_DEPENDS=	libgphoto2.so:${PORTSDIR}/g
>> 		libpeas-1.0.so:${PORTSDIR}/devel/libpeas
>> RUN_DEPENDS:=	${BUILD_DEPENDS}
> 
> Isn't itstool(1) a build-time only tool?  If so, it means that BUILD_DEPENDS
> is no longer equal to RUN_DEPENDS, so I think they have to be set explicitly
> now.  Alternatively, you can first set RUN_DEPENDS (mate-icon-theme), then
> assign BUILD_DEPENDS:= ${RUN_DEPENDS} itstool:${PORTSDIR}/textproc/itstool,
> but it's kind of in bogus order, we probably should not encourage this.
> 
> ./danfe
>