svn commit: r381760 - in head/x11-fonts/sourcesanspro-ttf: . files

Adam Weinberger adamw at adamw.org
Fri Mar 20 18:43:27 UTC 2015


> On 20 Mar, 2015, at 12:35, Baptiste Daroussin <bapt at FreeBSD.org> wrote:
> 
> On Fri, Mar 20, 2015 at 01:26:29PM -0500, Bryan Drewery wrote:
>> On 3/20/2015 1:23 PM, Baptiste Daroussin wrote:
>>> +WRKSRC=		${WRKDIR}/${GH_PROJECT}-${GH_TAGNAME:S,/,-,}
>> 
>> I think we should put this globally in this 1 line:
>> 
>> bsd.port.mk
>> 1561 .    if defined(GH_TAGNAME)
>> 1562 WRKSRC?=        ${WRKDIR}/${GH_PROJECT}-${GH_TAGNAME}
>> 
>> 
>> After https://reviews.freebsd.org/D2103 is resolved I will fix that.
> 
> Almost in this case upstream decided to put a / in the TAGNAME which is ... well
> ... :)

It would be so unbelievably nice if we had a way to just specify the destination filename, using fetch -o. All the bizarre names that files are published as, the unversioned tarballs, the documentation files labelled Documentation.pdf, and the fallout from changes like this.... we could make our lives so much easier with a DISTFILE_DEST variable.

# Adam


-- 
Adam Weinberger
adamw at adamw.org
http://www.adamw.org



More information about the svn-ports-head mailing list