svn commit: r380367 - head/textproc/docbook-xml

[Antoine Brodin]

On Tue, Mar 3, 2015 at 2:17 PM, Bartek Rutkowski <robak at freebsd.org> wrote:
>
>> Wiadomość napisana przez Antoine Brodin <antoine at FreeBSD.org> w dniu 3 mar 2015, o godz. 14:08:
>>
>> On Tue, Mar 3, 2015 at 1:54 PM, Bartek Rutkowski <robak at freebsd.org> wrote:
>>> Author: robak
>>> Date: Tue Mar  3 13:54:43 2015
>>> New Revision: 380367
>>> URL: https://svnweb.freebsd.org/changeset/ports/380367
>>> QAT: https://qat.redports.org/buildarchive/r380367/
>>>
>>> Log:
>>>  textproc/docbook-xml: fix build
>>>
>>>  - Change RUN_DEPENDS to BUILD_DEPENDS
>>>
>>>  PR:           191866
>>>  Submitted by: Martin Simmons <martin at lispworks.com>
>>>  MFH:          2015Q1
>>>
>>> Modified:
>>>  head/textproc/docbook-xml/Makefile
>>>
>>> Modified: head/textproc/docbook-xml/Makefile
>>> ==============================================================================
>>> --- head/textproc/docbook-xml/Makefile  Tue Mar  3 13:49:32 2015        (r380366)
>>> +++ head/textproc/docbook-xml/Makefile  Tue Mar  3 13:54:43 2015        (r380367)
>>> @@ -11,7 +11,7 @@ DISTFILES=    ${DBFILES:C,.*:(.*),\1.zip:\1
>>> MAINTAINER=    doceng at FreeBSD.org
>>> COMMENT=       DocBook XML DTD
>>>
>>> -RUN_DEPENDS=   ${LOCALBASE}/share/xml/xmlcharent/catalog.xml:${PORTSDIR}/textproc/xmlcharent \
>>> +BUILD_DEPENDS= ${LOCALBASE}/share/xml/xmlcharent/catalog.xml:${PORTSDIR}/textproc/xmlcharent \
>>>                ${XMLCATMGR_CMD}:${PORTSDIR}/textproc/xmlcatmgr
>>>
>>> NO_BUILD=      yes
>>
>>
>> Hi,
>>
>> Did you test all ports depending on docbook-xml?
>> textproc/docbook-xml is a NO_BUILD port so this looks wrong.
>>
>> Cheers,
>>
>> Antoine
>
> I havent tested all ports depending on it, but I have tested the build in poudriere on 8.4, 9.3 and 10.1 i386/amd64 without any issues and it was tested by few people in the PR 191866.
>
> Do you have any issues with it? I am asking, because I am just about to merge it into 2015Q1, what’s already approved by portmgr.


% pkg info -RF docbook-xml-5.0_2.txz
...
scripts: {
    post-install: "/usr/local/bin/xmlcatmgr -c
/usr/local/share/xml/catalog.ports add nextCatalog
/usr/local/share/xml/docbook/catalog.xml\n/usr/local/bin/xmlcatmgr -sc
/usr/local/share/sgml/catalog.ports add CATALOG
/usr/local/share/xml/docbook/catalog",
    post-deinstall: "/usr/local/bin/xmlcatmgr -c
/usr/local/share/xml/catalog.ports remove nextCatalog
/usr/local/share/xml/docbook/catalog.xml\n/usr/local/bin/xmlcatmgr -sc
/usr/local/share/sgml/catalog.ports remove CATALOG
/usr/local/share/xml/docbook/catalog"
}


So xmlcatmgr is definitely a RUN_DEPENDS

Cheers,

Antoine