svn commit: r380211 - head/security/libgpg-error

[Antoine Brodin]

On Sun, Mar 1, 2015 at 9:09 PM, John Marino <freebsd.contact at marino.st> wrote:
> On 3/1/2015 21:05, Antoine Brodin wrote:
>> On Sun, Mar 1, 2015 at 8:25 PM, John Marino <freebsd.contact at marino.st> wrote:
>>> On 3/1/2015 19:46, Antoine Brodin wrote:
>>>> Can you try using cpp5 -P instead of cpp5?
>>>> See http://www.gnu.org/software/gcc/gcc-5/porting_to.html
>>>>
>>>
>>> It works.  If I just add "CPP= cpp -P" to the stock port makefile, then
>>> it builds fine.  I check "cpp -P" on FreeBSD 10, it seems clang cpp just
>>> ignores the -P even though it's not a listed option.
>>>
>>> I guess if we want to use this, the fix would be something like
>>> "CPP+= -P"
>>>
>>> Would all the FreeBSD releases accept "CPP+= -P" ?
>>
>> I tested the src/Makefile.in part of
>> https://build.opensuse.org/source/openSUSE:Factory/libgpg-error/libgpg-error-1.18-gcc5.patch
>> on FreeBSD 8.4 / 9.3 / 10.1 / head / head with clang 3.6 and it
>> worked.
>
> Nice to know.  What is the rationale for patching the makefiles if
> defining CPP in the environment has the same result?
>
> Just curious because it seems that "CPP+= -P" saves three patches and
> I'd think that would be desired.

A patch can be submitted upstream (it's not fixed in libgpg-error git
and no one opened a bug about it yet)

Cheers,

Antoine