svn commit: r378316 - head/devel/libhtp

[John Marino]

On 2/3/2015 01:50, Kubilay Kocak wrote:
> On 3/02/2015 11:26 AM, John Marino wrote:
> 
> Is the blanket for DFly and/or simple "non-invasive" *FLAGS changes
> documented anywhere or does it only apply to individuals?

It's basically for DragonFly since the majority of committers cannot
test their commits on it.  Until redports comes back online with a
dragonfly backend, it's not reasonable to expect people to test their
commits don't break it.  It's also a ton of work to chase breakage, thus
simple fixes are blanketed.


> If you can sort out a proper fix in the right place that would be great.
> You have approval from me to revert/change devel/libhtp as necessary.

You asked where the fix was better.  It is better in uses/iconv.mk.
However, there was only one known broken port, devel/libhtp.  I didn't
have the resources to do an exp-run on use/bsd.iconv.mk, and obviously
that's not a quick (blanketed) fix.  So I am not planning on updating
that file, at least not any time soon.  My "to-do" list is quite long at
the moment.


> I appreciate not everyone is online or working at the same time.
> 
> Consideration is the key here, even if it resulted in the same outcome
> (a commit not *requiring* approval). Mindfulness and collaboration can
> sometimes take a little more effort, definitely.


Well, also remember there was a culture were people were terrified of
fixing simple things because some folks went ballistic if they were not
consulted and explicitly give approval even for typos.  Thankfully that
seems to have mostly passed.  This reaction has has now cost me 2 emails
for a single flag.  If the fix broke something or isn't the best fix, I
take responsibility and will correct or revert it.

Before the commit, I figured there was a 50/50 chance that you'd squawk
at this.  I was curious so I tested the waters.  I think the result is
in the future I'll be more prone to just drop in a local patch.

John