svn commit: r404326 - head/shells/zsh

Baptiste Daroussin bapt at FreeBSD.org
Wed Dec 23 23:14:08 UTC 2015


On Wed, Dec 23, 2015 at 10:56:46PM +0000, Adam Weinberger wrote:
> Author: adamw
> Date: Wed Dec 23 22:56:46 2015
> New Revision: 404326
> URL: https://svnweb.freebsd.org/changeset/ports/404326
> 
> Log:
>   Partially revert r403755. It can't build the curses module against ncurses from
>   ports. It probably can, but configure is too smart to figure that out.
>   
>   I have no confidence that linking against curses from ports results in a properly
>   working zshell. So, for now, back out the change. It will build a shared lib zsh
>   against ncurses from ports, but breaks statically-linked zsh's. Mark the port
>   as IGNORE if we're using ncurses from ports and building a static zsh.
>   
>   Also, remove a regression-test target that isn't useful anymore (thanks to bapt
>   for the reminder about this).
>   
>   I am not enthused about this change. It doesn't really "fix" the below PR, so
>   much as shoot ourselves in the other foot instead.
>   
>   PR:	205500
> 
The solution is to make --with-term-lib="tinfow tinfo" only when building static
because when building static you will never build the curses module

something like --with-term-lib="${TERMLIB}"
TERMLIB="ncursesw ncurses"

then later:
.if ${PORT_OPTIONS:MSTATIC}
TERMLIB="tinfow tinfo"
.endif

Which will also fix static building with base the day we split libtinfo* from
libncurses, which would be nice to do in base :)

Best regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20151224/7660ba3b/attachment.sig>


More information about the svn-ports-head mailing list