svn commit: r403235 - head/emulators/fuse-roms

[Mathieu Arnold]

+--On 8 décembre 2015 07:46:38 -0700 Adam Weinberger <adamw at adamw.org>
wrote:
|> On 8 Dec, 2015, at 4:45, Mathieu Arnold <mat at FreeBSD.org> wrote:
|> 
|> 
|> 
|> +--On 8 décembre 2015 11:46:01 +0100 René Ladan <rene at freebsd.org>
|> wrote:
|> | 2015-12-08 11:29 GMT+01:00 Mathieu Arnold <mat at freebsd.org>:
|> |> +--On 8 décembre 2015 10:08:19 +0100 René Ladan <rene at freebsd.org>
|> |> wrote:
|> |> | 2015-12-08 10:04 GMT+01:00 Mathieu Arnold <mat at freebsd.org>:
|> |> |> +--On 7 décembre 2015 21:00:16 +0000 Rene Ladan <rene at FreeBSD.org>
|> |> |> wrote:
|> |> |> | +DOCS_PLIST_FILES=%%DOCSDIR%%/rom-distribution.txt
|> |> |> 
|> |> |> When possible, don't use %%FOO%% thingies in PLIST_FILES, you can
|> |> |> use ${DOCSDIR} directly.
|> |> |> 
|> |> | I think I tried that before. It would almost work but "poudriere
|> |> | testport" would fail.
|> |> 
|> |> Then there was a bug in poudriere testport at that time. It now works.
|> |> 
|> | That was in the previous version (3.10.9 ?). 'make check-plist' worked
|> | fine. I'll change the line next time (but why is it bad?)
|> 
|> The only reason there are %%foo%% thingies is because pkg-plist is a
|> static file, and we need some way to do the variable expansion in them.
|> The PLIST_FILES is in the Makefile, you can put the correct variables
|> directly.
| 
| Wouldn't using ${DOCSDIR_REL} be closer to what %%DOCSDIR%% expands to?

Well, it doesn't matter.  If you want to write 4 more characters so that
you get a relative path that needs to be made absolute later, you can.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 949 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20151208/b5140414/attachment.sig>