svn commit: r383191 - head/Mk

[Bryan Drewery]

On 4/9/2015 11:03 AM, Alexey Dokuchaev wrote:
> On Thu, Apr 09, 2015 at 10:51:00AM -0500, Bryan Drewery wrote:
>> On 4/9/2015 10:38 AM, Alexey Dokuchaev wrote:
>>> I'm personally heavily relying on ability to set OSVERSION to arbitrary
>>> value on per-port basis; it is very helpful to test the logic of some
>>> complicated port (e.g. x11/nvidia-driver) to make sure you got all these
>>> checks right.  Now since r369644 (also by you) I have to comment that
>>> harness code from Mk/bsd.port.mk out.
>>>
>>> I was actually surprised that I have to do it, since log message talks
>>> only about "OSVERSION or UNAME_r is improperly set when building in a
>>> jail/chroot", but in reality I cannot do a "make OSVERSION=xxx" even when
>>> building locally. [...]
>>
>> Read the commit log again for r369644. Setting one var and not the other
>> leads to incorrect behavior in many ports. You must have them matching.
>> It is not just about jails/chroots.
> 
> I've (re)read it and understand what you're trying to accomplish; my point
> here is not to *build* things against custom OSVERSION, but just check if
> some variables are set correctly, e.g. "make -V FOO OSVERSION=xxx" is what
> I miss.  Is there a way to allow it again somehow?
> 
> ./danfe
> 

I understand what you're trying to do and I agree it would be useful if
it worked. Validating port logic (such as whether EXTRA_PATCHES has
something) based on OSVERSION is very useful. I'll think about how to
fix it.

-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20150409/40728873/attachment.sig>