svn commit: r383472 - head/audio/muse

[Adam Weinberger]

> On 6 Apr, 2015, at 19:29, Alexey Dokuchaev <danfe at FreeBSD.org> wrote:
> 
> On Mon, Apr 06, 2015 at 06:59:20PM +0000, Sunpoet Po-Chuan Hsieh wrote:
>> New Revision: 383472
>> URL: https://svnweb.freebsd.org/changeset/ports/383472
>> 
>> [...]
>> @@ -52,6 +49,6 @@ post-patch:
>> 
>> post-install:
>> 	@${MKDIR} ${STAGEDIR}${DOCSDIR}
>> -	${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}
>> +	(cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${STAGEDIR}${DOCSDIR})
> 
> Please do not change working and readable code into equivalent less-readable
> one.


${PORTDOCS:S,^,${WRKSRC}/,}

is not readable. Especially not compared to the pseudo-English statement into which sunpoet expanded it:

cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS}

Alexey, you've been ramping up the style policing lately. You're not getting much attention when you are choosing a different thing to care about each day. Pick just one or two topics that are most important to you, and work to get those behaviors fixed. Otherwise, sorry bud, you're just micro-managing.

# Adam


-- 
Adam Weinberger
adamw at adamw.org
http://www.adamw.org