svn commit: r382919 - in head/games/freedoko: . files
Alexey Dokuchaev
danfe at FreeBSD.org
Wed Apr 1 16:29:11 UTC 2015
On Wed, Apr 01, 2015 at 04:07:18PM +0000, Bartek Rutkowski wrote:
> New Revision: 382919
> URL: https://svnweb.freebsd.org/changeset/ports/382919
>
> [...]
> do-install:
> - ${INSTALL_PROGRAM} ${WRKSRC}/FreeDoko ${STAGEDIR}${PREFIX}/bin
> + (cd ${WRKSRC} && ${INSTALL_PROGRAM} FreeDoko \
> + ${STAGEDIR}${PREFIX}/bin)
And here I come again: why was this change needed? New version is bogus:
it's not $cwd-agnostic, it's split into two commands and thus requires a
"context" to follow; it functionally changes *nothing* and thus is clearly
a gratuitous change. How many times do I have to explain this? :(
> - cd ${WRKSRC}/../doc/manual && ${FIND} . | \
> - ${CPIO} --quiet -pdum ${STAGEDIR}${DOCSDIR}
> - @${RMDIR} ${STAGEDIR}${DOCSDIR}/de/pictures
> + @(cd ${WRKSRC}/../doc/manual && ${COPYTREE_SHARE} . \
> + ${STAGEDIR}${DOCSDIR})
We do not encourage muting installation commands.
./danfe
More information about the svn-ports-head
mailing list