svn commit: r369243 - head/net/trickle

[Tijl Coosemans]

On Thu, 25 Sep 2014 15:06:10 +0200 Pietro Cerutti <gahr at FreeBSD.org> wrote:
> On 2014-Sep-25, 14:53, Tijl Coosemans wrote:
>> On Thu, 25 Sep 2014 11:59:47 +0000 (UTC) Pietro Cerutti <gahr at FreeBSD.org> wrote:
>>> Author: gahr
>>> Date: Thu Sep 25 11:59:46 2014
>>> New Revision: 369243
>>> URL: http://svnweb.freebsd.org/changeset/ports/369243
>>> QAT: https://qat.redports.org/buildarchive/r369243/
>>> 
>>> Log:
>>>   - Generate position independent code
>>>   - Perhaps this fixes the build on head-amd64-default-ssp
>>> 
>>> Modified:
>>>   head/net/trickle/Makefile
>>> 
>>> Modified: head/net/trickle/Makefile
>>> ==============================================================================
>>> --- head/net/trickle/Makefile	Thu Sep 25 11:35:43 2014	(r369242)
>>> +++ head/net/trickle/Makefile	Thu Sep 25 11:59:46 2014	(r369243)
>>> @@ -22,7 +22,7 @@ MAKE_JOBS_UNSAFE=	yes
>>>  
>>>  CONFIGURE_ARGS+=--with-libevent=${LOCALBASE} \
>>>  		--sysconfdir=${PREFIX}/etc
>>> -CPPFLAGS+=	-I${LOCALBASE}/include
>>> +CPPFLAGS+=	-I${LOCALBASE}/include -fPIC
>> 
>> The problem with adding -fPIC like that is that it causes everything
>> to be compiled with it, including executables and static libraries
>> while normally only shared libraries need it.
> 
> Is this a problem?

Depends on what you call problem.  It's a performance issue.  PIC is
slower than non-PIC.  For executables there's -fPIE which is a bit
less slow.

>> In the configure output for the SSP build it says:
>> 
>> checking if cc PIC flag -fPIC works... no
>> 
>> 
>> Can you check config.log to see why this test fails?
> 
> No, I don't have the working directory myself. Anyway, it looks like
> it fails to link because -fPIC wasn't specified, not that it fails to
> compile because of the -fPIC flag. Or am I missing something?

The first yes, but the reason it isn't specified is because the
configure check fails.  The reason the configure check fails seems
to be because the SSP package builder uses ccache.  It doesn't support
clang properly.

I think you can just revert the commit.  It is not needed at all.  You
can test it with "make -DWITH_SSP_PORTS".