svn commit: r368241 - in head/sysutils: . jadm jadm/files

[Ruslan Makhmatkhanov]

Jason E. Hale wrote on 15.09.2014 20:05:
> On Mon, Sep 15, 2014 at 10:36 AM, Adam Weinberger <adamw at adamw.org> wrote:
>> On 15 Sep, 2014, at 3:50, Jason E. Hale <jhale at FreeBSD.org> wrote:
>>
>>> On Sun, Sep 14, 2014 at 10:27 PM, Vanilla I. Shu <vanilla at freebsd.org> wrote:
>>>>
>>>> +BUILD_DEPENDS= ${PYTHON_LIBDIR}/site-packages/paramiko/:${PORTSDIR}/security/py-paramiko \
>>>> +               ${PYTHON_LIBDIR}/site-packages/netifaces.so:${PORTSDIR}/net/py-netifaces \
>>>> +               ${PYTHON_LIBDIR}/site-packages/tabulate.py:${PORTSDIR}/devel/py-tabulate \
>>>> +               ${PYTHON_LIBDIR}/site-packages/ipaddress.py:${PORTSDIR}/net/py-ipaddress
>>>
>>> This is a deprecated style of depending on other Python ports.
>>> Format should be:
>>> BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}paramiko>=0:${PORTSDIR}/security/py-paramiko
>>
>> I had no idea that format was deprecated. Perhaps an example could be added to the PHB or Uses/python.mk?
>>
> I'm sure the Python section of the PHB could use some attention.  It
> still references the old USE_PYTHON and
> bsd.python.mk instead of USES=python and Uses/python.mk among other things.
>
> The format I mentioned is the one I have seen in most Python and Perl
> ports, however, Uses/python.mk has a mix
> of both styles. I guess "deprecated" was a little strong, that's more
> of an official word.  "Not so common" might be
> more appropriate.  To me, it looks cleaner and allows for version
> checking.  Even still, ${PYTHON_SITELIBDIR}
> would be preferable to ${PYTHON_LIBDIR}/site-packages.

Putting my python@ hat on, I'd suggest to use this syntax instead:

${PYTHON_PKGNAMEPREFIX}paramiko>0:${PORTSDIR}/security/py-paramiko

The main point is to depend on package, not on specific file in the 
filesystem.

But the actual problem is that this port, being a python script, make it 
effectively useless when installing from a package. Because the 
dependencies are defined as BUILD one, while it actually needs them to 
run. So, they should be defined as RUN_DEPENDS only or, if the port 
checks of their existence withing installation process, both on BUILD_ 
and RUN_DEPENDS.

-- 
Regards,
Ruslan

T.O.S. Of Reality