svn commit: r367404 - in head/security: . webshag webshag/files

[clutton]

On Mon, 2014-09-08 at 01:42 +0200, Baptiste Daroussin wrote:
> On Sat, Sep 06, 2014 at 11:51:42AM +0200, John Marino wrote:
> > On 9/6/2014 11:32, Kubilay Kocak wrote:
> > > On 6/09/2014 5:46 PM, Carlo Strub wrote:
> > >> +LICENSE=	GPLv3
> > > 
> > > LICENSE_FILE
> > 
> > I know mat's position, but this decree was definitely controversial.
> > Many people don't agree that LICENSE_FILE is needed when the provided
> > license is identical to the one offered in ports Templates directory.
> > And since the licensing framework is still an unsupported and mostly
> > undocumented red-headed stepchild of ports, I don't think I agree with
> > saying this was an error.
> > 
> > >> +bin/webshag_cli
> > >> +%%WXGTK%%bin/webshag_gui
> > >> +%%ETCDIR%%.conf
> > > 
> > > Does this need a filename?
> > 
> > 
> > This is probably a wonderful side effect of make makeplist which
> > aggressively creates SUB replacements, often incorrectly.
> > This was probably /etc/${PORTNAME}.conf and it got transformed and
> > submitter didn't check closely enough.
> > 
> > I agree, DO NOT TRUST MAKEPLIST FURTHER THAN YOU CAN THROW IT!
> > 
> This is why the first line of make makeplist if wrong so one has to review!
> 
> regards,
> Bapt

I've just fixed the port. And there is how I made mistake:
%%WXGTK%% is an option which defines from (OPTIONS_DEFINE=NMAP WXGTK and
OPTIONS_SUB=yes) so there's no need for /. And %%ETCDIR%% is a path.

We have some ambiguously here with OPTIONS framework.

Should there be the space? Between the %%WXGTK%% and the
bin/webshag_gui? Observing other ports I can't see the space between...