svn commit: r367404 - in head/security: . webshag webshag/files

John Marino freebsd.contact at marino.st
Sat Sep 6 09:52:20 UTC 2014


On 9/6/2014 11:32, Kubilay Kocak wrote:
> On 6/09/2014 5:46 PM, Carlo Strub wrote:
>> +LICENSE=	GPLv3
> 
> LICENSE_FILE

I know mat's position, but this decree was definitely controversial.
Many people don't agree that LICENSE_FILE is needed when the provided
license is identical to the one offered in ports Templates directory.
And since the licensing framework is still an unsupported and mostly
undocumented red-headed stepchild of ports, I don't think I agree with
saying this was an error.

>> +bin/webshag_cli
>> +%%WXGTK%%bin/webshag_gui
>> +%%ETCDIR%%.conf
> 
> Does this need a filename?


This is probably a wonderful side effect of make makeplist which
aggressively creates SUB replacements, often incorrectly.
This was probably /etc/${PORTNAME}.conf and it got transformed and
submitter didn't check closely enough.

I agree, DO NOT TRUST MAKEPLIST FURTHER THAN YOU CAN THROW IT!


John



More information about the svn-ports-head mailing list