svn commit: r367212 - in head: astro/planets devel/aifad ftp/ocaml-ocurl

[John Marino]

On 9/3/2014 17:43, Alexey Dokuchaev wrote:
> On Wed, Sep 03, 2014 at 05:29:39PM +0200, Antoine Brodin wrote:
>> On Wed, Sep 3, 2014 at 5:28 PM, Alexey Dokuchaev <danfe at freebsd.org> wrote:
>>> Hey Antoine, can you explain what's going on here?  Lots of ports are using
>>> PLIST_FILES/PORTDOCS to avoid spamming the tree with little pkg-plist files,
>>> and now you're essentially reverting it back.
>>
>> It fails to package because bsd.ocaml.mk is stupid, i just fix.
> 
> OK; I actually have an idea to convert bsd.ocaml.mk to Uses/ocaml.mk.  That
> said, I once again want to remind (all of us) of the importance of providing
> enough information in the commit logs.  "Fix build" does not really explain
> anything and only rises questions like mine.
> 
> Please spend 30 seconds more to shut us up. :-)

Frankly, "bsd.ocaml.mk is stupid" doesn't help me either.

e.g.
What about it is "stupid"?
Why can't it be fixed?
Why is reverting good code to less desirable code a better idea than
fixing bsd.ocaml.mk?

With no information to judge, this commit doesn't look right to me.  So
I second the request for a lot better commit messages and particularly
elaboration on this one, which caused to people to say "wth?" within a
minute.

John