svn commit: r366841 - head/lang/tcl86/files

[Pietro Cerutti]

On 2014-Sep-01, 17:01, John Marino wrote:
> On 9/1/2014 16:47, Adam Weinberger wrote:
> > On 1 Sep, 2014, at 3:46, Alexey Dokuchaev <danfe at FreeBSD.org> wrote:
> >> Since when did we abandon the practice of doing 'svn diff' before
> >> commit?
> > 
> > Alexey, please direct your frustration elsewhere. Pietro fixed
> > (hopefully) a problem that caused a lot of tcl-dependent ports to
> > break. He should be commended, not sneered at. If you don’t like the
> > way makepatch works, take it up with portmgr, not with the committers
> > who use it. I know for a fact that portmgr is interested in extending
> > makepatch to DTRT.
> > 
> > Besides, there are simply situations where makepatch is just not the
> > tool to use. Sometimes I *have* to run diff(1) by hand. Sometimes I
> > need to run "make patch” before I can edit the diff. Sometimes I’ve
> > edited multiple files and I want to test one diff at a time.
> > Sometimes a file needs to be touched by two different patches (I
> > don’t like it, but ten years ago it seems like people really did).
> 
> 
> While I also pushed back against danfe@ on this post, it's obvious that
> makepatch was used.  The commit didn't do anything except change the
> timestamp.

I'm sorry to contradict the obvious, but I've never ever used makepatch
in my life. I didn't even know it existed before danfe@'s email. I
always generated my patch with diff -uN.

Moreover, the commit clearly *did* do things other than change the
timestamp.

https://svnweb.freebsd.org/ports/head/lang/tcl86/files/patch-unix-Makefile.in?r1=366841&r2=366840

-- 
Pietro Cerutti
The FreeBSD Project
gahr at FreeBSD.org

PGP Public Key:
http://gahr.ch/pgp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 949 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20140902/6c1c1770/attachment.sig>